Skip to content

Add imagePullSecrets to predeploy tests #29340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebdekock wants to merge 2 commits into from
Closed

Add imagePullSecrets to predeploy tests #29340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f891893
Add imagePullSecrets to predeploy tests
ebdekock Jul 20, 2023
524a0bd
Merge branch 'master' into add_imagepullsecrets_test_jobs
ebdekock Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/chart/teleport-cluster/templates/auth/predeploy_job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ spec:
{{- end }}
{{- if $auth.tolerations }}
tolerations: {{- toYaml $auth.tolerations | nindent 6 }}
{{- end }}
{{- if $auth.imagePullSecrets }}
imagePullSecrets:
{{- toYaml $auth.imagePullSecrets | nindent 6 }}
{{- end }}
restartPolicy: Never
containers:
Expand Down
4 changes: 4 additions & 0 deletions examples/chart/teleport-cluster/templates/proxy/predeploy_job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ spec:
{{- end }}
{{- if $proxy.tolerations }}
tolerations: {{- toYaml $proxy.tolerations | nindent 6 }}
{{- end }}
{{- if $proxy.imagePullSecrets }}
imagePullSecrets:
{{- toYaml $proxy.imagePullSecrets | nindent 6 }}
{{- end }}
restartPolicy: Never
containers:
Expand Down
6 changes: 6 additions & 0 deletions examples/chart/teleport-cluster/tests/__snapshot__/predeploy_test.yaml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
should set imagePullSecrets on auth predeploy job when set in values:
1: |
- name: myRegistryKeySecretName
should set imagePullSecrets on proxy predeploy job when set in values:
1: |
- name: myRegistryKeySecretName
22 changes: 22 additions & 0 deletions examples/chart/teleport-cluster/tests/predeploy_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,25 @@ tests:
- equal:
path: spec.template.spec.containers[0].resources.requests.memory
value: 2Gi

- it: should set imagePullSecrets on proxy predeploy job when set in values
template: proxy/predeploy_job.yaml
values:
- ../.lint/imagepullsecrets.yaml
asserts:
- equal:
path: spec.template.spec.imagePullSecrets[0].name
value: myRegistryKeySecretName
- matchSnapshot:
path: spec.template.spec.imagePullSecrets

- it: should set imagePullSecrets on auth predeploy job when set in values
template: auth/predeploy_job.yaml
values:
- ../.lint/imagepullsecrets.yaml
asserts:
- equal:
path: spec.template.spec.imagePullSecrets[0].name
value: myRegistryKeySecretName
- matchSnapshot:
path: spec.template.spec.imagePullSecrets