[v12] update discovery labels#29271
Merged
GavinFrazar merged 1 commit intobranch/v12from Jul 19, 2023
Merged
Conversation
Backport #28917 to branch/v12 * update discovery labels and name overrides * move all labels into api/types/constants.go * add name override labels for GKE and AKS that are allowed tag names in GCP and Azure * support legacy and cloud-agnostic name override labels for AWS * add tests for creating kube clusters from cloud kube clusters
tigrato
approved these changes
Jul 18, 2023
fspmarshall
approved these changes
Jul 19, 2023
alexfornuto
approved these changes
Jul 19, 2023
GavinFrazar
deleted the
gavinfrazar/v12-move-discovery-added-labels-into-constants
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #28917 to branch/v12
there were some minor merge conflicts, all of which came from the cherry-pick including things that weren't in v12 unrelated to this PR's intended changes to discovery labels.