Skip to content

[RFD] 0143 - External Kubernetes Joining#29225

Merged
strideynet merged 21 commits intomasterfrom
rfd/0143-external-k8s-joining
Sep 11, 2023
Merged

[RFD] 0143 - External Kubernetes Joining#29225
strideynet merged 21 commits intomasterfrom
rfd/0143-external-k8s-joining

Conversation

@strideynet
Copy link
Copy Markdown
Contributor

@strideynet strideynet commented Jul 17, 2023

This RFD proposes a method for allowing entities (such as a Machine ID instance
or an Agent) to join Teleport Clusters via federation between the Kubernetes
Cluster they reside in and a Teleport Cluster, where that Teleport Cluster does
not reside in the same Kubernetes Cluster.

Part of #25543

@strideynet strideynet requested review from hugoShaka and tigrato July 17, 2023 21:43
Comment thread rfd/0143-external-k8s-joining.md Outdated
Comment thread rfd/0143-external-k8s-joining.md Outdated
Comment thread rfd/0143-external-k8s-joining.md
Comment thread rfd/0143-external-k8s-joining.md Outdated
@hugoShaka hugoShaka added the rfd Request for Discussion label Jul 18, 2023
Comment thread rfd/0143-external-k8s-joining.md
Comment thread rfd/0143-external-k8s-joining.md
Comment thread rfd/0143-external-k8s-joining.md Outdated
Comment thread rfd/0143-external-k8s-joining.md
Comment thread rfd/0143-external-k8s-joining.md Outdated
Comment thread rfd/0143-external-k8s-joining.md Outdated
Comment thread rfd/0143-external-k8s-joining.md
@hugoShaka hugoShaka requested a review from webvictim July 18, 2023 21:13
@strideynet strideynet marked this pull request as ready for review July 25, 2023 15:27
@strideynet strideynet requested review from hugoShaka and tigrato July 25, 2023 15:28
@github-actions github-actions Bot requested review from greedy52 and rosstimothy July 25, 2023 15:28
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only remaining concern with the model is the infinitely renewable token. We might want folks from security to look at this. IIRC, we asked for an external audit last time I added a joining method.

Copy link
Copy Markdown
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for security audit

@strideynet
Copy link
Copy Markdown
Contributor Author

strideynet commented Aug 2, 2023

image

Copy link
Copy Markdown
Contributor

@jentfoo jentfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risks are well articulated. I don't see any additional risks, or room for improvement. However I have sent this to Doyensec so they can additionally review this RFD.

Comment thread rfd/0143-external-k8s-joining.md Outdated
Co-authored-by: Mike Jensen <jentfoo@users.noreply.github.com>
@strideynet strideynet added the blocked is blocked by another item - please include the blocker label Aug 8, 2023
@strideynet
Copy link
Copy Markdown
Contributor Author

"Blocked" awaiting an external review.

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Aug 22, 2023

Any new audit events as part of this work? We often get dinged in security reviews for missing audit events, and despite having a section dedicated to them in the RFD template I don't see any information on them here.

@strideynet
Copy link
Copy Markdown
Contributor Author

@zmb3 I'll add this to the RFD - in the actual implementation I've not added any new audit events (since we already emit them for Bot/Agent joins) - but I have improved the richness of the existing Kubernetes Join audit event in a similar way that we do for GitHub joining (e.g the token fields are included in the audit event).

@strideynet
Copy link
Copy Markdown
Contributor Author

Completed in 42f9d3a

Copy link
Copy Markdown

@SzymonDrosdzol SzymonDrosdzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a couple of small improvements to JWT validation process for consideration.
Otherwise, looks good.

Comment thread rfd/0143-external-k8s-joining.md
Comment thread rfd/0143-external-k8s-joining.md
Comment thread rfd/0143-external-k8s-joining.md
@strideynet strideynet removed blocked is blocked by another item - please include the blocker backport/branch/v12 labels Sep 11, 2023
@strideynet strideynet added this pull request to the merge queue Sep 11, 2023
Merged via the queue into master with commit 95a07b7 Sep 11, 2023
@strideynet strideynet deleted the rfd/0143-external-k8s-joining branch September 11, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfd Request for Discussion size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants