fix database dynamic labels#29215
Merged
GavinFrazar merged 3 commits intomasterfrom Jul 20, 2023
Merged
Conversation
* fix locking in apps/databases service
GavinFrazar
added
database-access
codingllama
approved these changes
Jul 18, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
I'm not super familiar with these parts, so I'm taking some of the changes at face value. Seems reasonable to me.
codingllama
approved these changes
Jul 18, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks, Gavin.
Well-spotted on the RWLocks, btw.
camscale
approved these changes
Jul 20, 2023
public-teleport-github-review-bot
Bot
removed request for
r0mant,
smallinsky and
zmb3
smallinsky
reviewed
Jul 20, 2023
|
@GavinFrazar See the table below for backport results.
|
GavinFrazar
added a commit
that referenced
this pull request
Jul 20, 2023
Backport #29215 to branch/v12
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
Backport #29215 to branch/v12
GavinFrazar
added a commit
that referenced
this pull request
Jul 20, 2023
Backport #29215 to branch/v11
This was referenced Jul 21, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
Backport #29215 to branch/v11
This was referenced Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7198
This PR updates the database retrieved for session RBAC checking (at connection time) to includes cloud and dynamic labels.
It also fixes some suspicious recursive read locking in the app server that could have caused a deadlock.