[v12] Use the examples directory for example plugin code#29151
Merged
alexfornuto merged 15 commits intobranch/v12from Jul 19, 2023
Merged
[v12] Use the examples directory for example plugin code#29151alexfornuto merged 15 commits intobranch/v12from
alexfornuto merged 15 commits intobranch/v12from
Conversation
Also edit the Access Request plugin API guide to use this directory, rather than having the reader copy/paste individual code snippets. This makes the guide easier to follow, and users will have a compilable example before they proceed through the guide.
This way, we can reuse the actual program in the Access Request plugin API guide and avoid unintended discrepancies and drift.
Need to test this out, but it compiles
- Types that are no longer reachable via public interfaces - The description of the demo implementation that used the old `watcherjob` package
Respond to Joerger feedback
Co-authored-by: Brian Joerger <bjoerger@goteleport.com>
- Split up "types.go". Reserve a single file for configuration values so these are visible in a single place within the guide. - Return an error on an unsuccessful HTTP request when creating or updating a row - Simplify requestStates lookup - Clearly mark values that a user must change - Update the text of the guide to match changes to the program
Contributor
Author
|
Please feel free to merge this for me! |
Joerger
approved these changes
Jul 14, 2023
zmb3
approved these changes
Jul 14, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from alexfornuto
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #23255 to branch/v12