Docs: numbering lint warnings batch 2#29093
Merged
lsgunn-teleport merged 0 commit intoLG/lint-numbering-4-14xfrom Jul 17, 2023
Merged
Docs: numbering lint warnings batch 2#29093lsgunn-teleport merged 0 commit intoLG/lint-numbering-4-14xfrom
lsgunn-teleport merged 0 commit intoLG/lint-numbering-4-14xfrom
Conversation
ptgott
approved these changes
Jul 14, 2023
alexfornuto
changed the title
alexfornuto
approved these changes
Jul 14, 2023
public-teleport-github-review-bot
Bot
removed request for
r0mant,
xinding33 and
zmb3
|
@lsgunn-teleport See the table below for backport results.
|
alexfornuto
pushed a commit
that referenced
this pull request
Jul 18, 2023
Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes
lsgunn-teleport
added a commit
that referenced
this pull request
Jul 18, 2023
Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes
lsgunn-teleport
added a commit
that referenced
this pull request
Jul 18, 2023
Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes
lsgunn-teleport
added a commit
that referenced
this pull request
Jul 18, 2023
Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes Additional fixes for linter
lsgunn-teleport
added a commit
that referenced
this pull request
Jul 19, 2023
Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes Additional fixes for linter
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes Additional fixes for linter
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Changes to ordered and unordered lists for lint warnings Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes * Additional fixes for linter --------- Co-authored-by: Lisa Gunn <lisa.gunn@goteleport.com> Co-authored-by: lsgunn-teleport <136391445+lsgunn-teleport@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…in 14.x (#29318) * Changes to ordered and unordered lists for lint warnings Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes * additional lint fixes --------- Co-authored-by: alexfornuto <alex.fornuto@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…29319) * Changes to ordered and unordered lists for lint warnings Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes * resolveNetworkAddress: Listen for `close` instead of `exit` (#29261) * Fix lint warning, make these unordered lists (#29210) * Changes to ordered and unordered lists for lint warnings Fix messed up spelling add missing punctuation, fir wording Docs: Ordered and unordered list changes for lint update (#29094) * Ordered and unordered list chnages for lint update * Fixes from Alex's review Docs: numbering lint warnings batch 2 (#29093) * Change ordered and unordered lists to squash lint warnings * Change ordered and unordered lists to squash lint warnings * Changes for lint update additional lint fixes Additional fixes for linter * Lint errors and warnings * More fixes to get rid of lint errors and warnings --------- Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com> Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lint warning prior to making the change to the behavior implemented in gravitational/docs#341.
Some of these files used numbers (ordered) lists but should have used bullets (unordered) lists.
Lint Docs will fail until the change in gravitational/docs#341 is merged.