fix forwarding a SSH agent in a Cygwin environment#29068
Merged
capnspacehook merged 7 commits intomasterfrom Aug 16, 2023
Merged
fix forwarding a SSH agent in a Cygwin environment#29068capnspacehook merged 7 commits intomasterfrom
capnspacehook merged 7 commits intomasterfrom
Conversation
mdwn
approved these changes
Jul 13, 2023
Contributor
mdwn
left a comment
mdwn
left a comment
There was a problem hiding this comment.
I can't imagine what it took to debug this. Good work!
zmb3
reviewed
Jul 13, 2023
zmb3
reviewed
Jul 13, 2023
zmb3
reviewed
Jul 13, 2023
r0mant
reviewed
Jul 14, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@capnspacehook Can you make a dev build and share with the customer to see if this fixes their issue?
jakule
reviewed
Jul 17, 2023
| } | ||
| psMatches := psLine.FindStringSubmatch(string(psOutput)) | ||
| if len(psMatches) != 2 { | ||
| return 0, trace.Errorf("error reading Cygwin ps output") |
Contributor
There was a problem hiding this comment.
Adding more information here would be helpful. I don't think that we will be able to figure out what is wrong if someone send us only this error.
Contributor
Author
jakule
approved these changes
Jul 19, 2023
capnspacehook
changed the title
Contributor
Author
|
Was finally able to get another build to the affected customer who confirmed the fix works! |
|
@capnspacehook See the table below for backport results.
|
This was referenced Aug 16, 2023
Collaborator
|
Nice job on this captain! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure of how to write a unit test this given that this bug is only reproducible on Windows with specific software installed.
Fixes #24823.