adds public web addresses to self-signed cert#28766
Merged
stevenGravy merged 19 commits intomasterfrom Jul 24, 2023
Merged
Conversation
zmb3
reviewed
Jul 6, 2023
strideynet
approved these changes
Jul 7, 2023
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Thanks for tackling this !
Co-authored-by: Noah Stride <noah.stride@goteleport.com>
strideynet
approved these changes
Jul 7, 2023
zmb3
requested changes
Jul 9, 2023
strideynet
reviewed
Jul 11, 2023
strideynet
approved these changes
Jul 11, 2023
| @@ -87,6 +87,10 @@ func GenerateSelfSignedCert(hostNames []string) (*Credentials, error) { | |||
| if ips != nil { | |||
Contributor
There was a problem hiding this comment.
Nit: It'd be tempted to rename ips to loopbackIPs or similar - just so its clearly distinct from ipAddresses in purpose.
Contributor
Author
|
Please take a look when you can @zmb3. |
zmb3
reviewed
Jul 24, 2023
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
zmb3
approved these changes
Jul 24, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from klizhentas
|
@stevenGravy See the table below for backport results.
|
This was referenced Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15004
Adds public addresses specified. If an error occurs parsing the public address it is logged and skipped.