[v13] Edit forScopes configurations and edit guides#28742
Merged
Conversation
github-actions
Bot
requested review from
alexfornuto,
lsgunn-teleport,
r0mant,
stevenGravy,
xinding33 and
zmb3
stevenGravy
approved these changes
Jul 5, 2023
This comment was marked as outdated.
This comment was marked as outdated.
ptgott
force-pushed
the
paul.gottschling/28443-bp-v13
branch
2 times, most recently
from
c398a0d to
83e7a33
Compare
alexfornuto
reviewed
Jul 7, 2023
| </TabItem> | ||
| <TabItem scope={["cloud"]} | ||
| label="Teleport Cloud"> | ||
| label="Teleport Enterprise Cloud"> |
Contributor
There was a problem hiding this comment.
@ptgott Should this remain just "Cloud" for instructions that apply to both Team and Enterprise Cloud, and have the commercial prereqs partial for when only Enterprise Cloud applies?
Contributor
Author
There was a problem hiding this comment.
When I created the original PR, I assumed that Team wouldn't require the Enterprise tctl client, so I made a separate tab. If Team does require Enterprise tctl, though, I think we can use "Teleport Team/Enterprise Cloud" as the label and use the same tab item for both Team and Enterprise Cloud.
Contributor
There was a problem hiding this comment.
I've confirmed that teams users should use enterprise tctl.
ptgott
force-pushed
the
paul.gottschling/28443-bp-v13
branch
from
83e7a33 to
e77986e
Compare
Backports #28443 * Edit forScopes configurations and edit guides Closes #26500 This change requires merging gravitational/docs#326 to add a Team scope to the docs. This updates pages within the docs so that: - Each page's `forScopes` configuration is accurate, especially with regard to support for Teleport Team. - All scoped components match the `forScopes` configuration for each page. For this, I used the linter introduced by gravitational/docs#327. * Respond to alexfornuto feedback
ptgott
force-pushed
the
paul.gottschling/28443-bp-v13
branch
from
e77986e to
267d31b
Compare
alexfornuto
approved these changes
Jul 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #28443
Closes #26500
This change requires merging gravitational/docs#326 to add a Team scope to the docs.
This updates pages within the docs so that:
forScopesconfiguration is accurate, especially with regard to support for Teleport Team.forScopesconfiguration for each page. For this, I used the linter introduced by Lint alignment of components withforScopesdocs#327.