Skip to content

assist: add execution and discussion usage events#28492

Merged
hugoShaka merged 1 commit intomasterfrom
hugo/assist-usage-event
Jul 26, 2023
Merged

assist: add execution and discussion usage events#28492
hugoShaka merged 1 commit intomasterfrom
hugo/assist-usage-event

Conversation

@hugoShaka
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka commented Jun 29, 2023 •
edited
Loading

@hugoShaka hugoShaka requested review from jakule and justinas June 29, 2023 20:48
@hugoShaka hugoShaka changed the title Hugo/assist usage event assist: add execution and discussion usage events Jun 29, 2023
justinas
justinas reviewed Jun 30, 2023
View reviewed changes
Comment thread api/proto/teleport/usageevents/v1/usageevents.proto
@hugoShaka hugoShaka mentioned this pull request Jun 30, 2023
Merged
@hugoShaka hugoShaka force-pushed the hugo/assist-usage-event branch from 2b291f4 to 7d1a5de Compare July 18, 2023 19:56
@hugoShaka
Copy link
Copy Markdown
Contributor Author

hugoShaka commented Jul 18, 2023

This PR must be rebased after #29224 is merged (or the other way around) as the token counting logic is changed in #29224 and this PR adds token counting on new model invocations.

@hugoShaka hugoShaka force-pushed the hugo/assist-usage-event branch from 7d1a5de to 496e645 Compare July 18, 2023 20:30
@hugoShaka hugoShaka marked this pull request as ready for review July 18, 2023 20:30
@github-actions github-actions Bot requested review from EdwardDowling and r0mant July 18, 2023 20:30
jakule
jakule approved these changes Jul 20, 2023
View reviewed changes
Comment thread lib/assist/assist_test.go Outdated
Comment thread proto/prehog/v1alpha/teleport.proto Outdated
Comment thread proto/prehog/v1alpha/teleport.proto Outdated
Comment thread proto/prehog/v1alpha/teleport.proto
Comment thread proto/prehog/v1alpha/teleport.proto
Comment thread api/proto/teleport/usageevents/v1/usageevents.proto
@hugoShaka hugoShaka requested a review from justinas July 21, 2023 14:25
@hugoShaka hugoShaka force-pushed the hugo/assist-usage-event branch 2 times, most recently from b027fb3 to 9e67d35 Compare July 25, 2023 22:27
justinas
justinas approved these changes Jul 26, 2023
View reviewed changes
Comment thread lib/ai/model/messages.go Outdated
@hugoShaka hugoShaka force-pushed the hugo/assist-usage-event branch from 9e67d35 to acac6ec Compare July 26, 2023 14:44
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from EdwardDowling July 26, 2023 15:15
@hugoShaka hugoShaka enabled auto-merge July 26, 2023 15:18
@hugoShaka hugoShaka added this pull request to the merge queue Jul 26, 2023
Merged via the queue into master with commit 915299a Jul 26, 2023
@hugoShaka hugoShaka deleted the hugo/assist-usage-event branch July 26, 2023 15:56
jakule pushed a commit that referenced this pull request Jul 31, 2023
@hugoShaka @jakule
assist: add classification code and emit even on execution (#28492)
2e208c9
@jakule jakule mentioned this pull request Jul 31, 2023
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jul 31, 2023
@jakule @hugoShaka
assist: add classification code and emit even on execution (#28492) (#…
86e49cc 
…29811)

Co-authored-by: Hugo Shaka <hugo.hervieux@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0mant r0mant r0mant approved these changes

+2 more reviewers

@justinas justinas justinas approved these changes

@jakule jakule jakule approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugoShaka @r0mant @justinas @jakule