Merged
Conversation
jakule
force-pushed
the
jakule/fix-windows-build-2
branch
from
c83edaf to
d11a8f2
Compare
jakule
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
zmb3
approved these changes
Jun 27, 2023
webvictim
approved these changes
Jun 27, 2023
rosstimothy
approved these changes
Jun 27, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from hugoShaka
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
This PR is failing on the MQ (which means that my fix is working), but I need to wait for the Windows fix to hit master before I can merge that change. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
ravicious
pushed a commit
that referenced
this pull request
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, "Build on Windows" build does not report failures even if they happen. This PR fixes this behavior.
Force triggered build as "Build on Windows" is skipped on PR push:
https://github.com/gravitational/teleport/actions/runs/5390670986/jobs/9786370966
Depends on #28357