InstallScripts: pin teleport version using ServerVersion#28149
InstallScripts: pin teleport version using ServerVersion#28149marcoandredinis merged 2 commits intomasterfrom
Conversation
marcoandredinis
force-pushed
the
marco/auto_upgrade_script_fix_stablecloud
branch
2 times, most recently
from
81ec1f4 to
9340eab
Compare
github-actions
Bot
added
machine-id
size/md
tctl
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@marcoandredinis Can you please also test it on a Cloud tenant to make sure we don't run into the same situation during upgrade as we did earlier this week?
There was a problem hiding this comment.
This change seems irrelevant to the issue.
There was a problem hiding this comment.
This was causing an import cycle because:
github.com/gravitational/teleport/lib/modules imports github.com/gravitational/teleport/lib/automaticupgrades imports github.com/gravitational/teleport/lib/utils imports github.com/gravitational/teleport/lib/modules: import cycle not allowed .
It was only used in our binaries and it was a one liner, so I just replaced the function call
There was a problem hiding this comment.
I would update this comment to explicitly mention that currently auto-upgrades in the install script are enabled only for Cloud customers enrolled in auto-upgrades. Otherwise, it looks strange that we're checking generic "installUpdater" variable but override the channel to the cloud one.
There was a problem hiding this comment.
Updated to:
// The install script will install the updater (teleport-ent-updater) for Cloud customers enrolled in Automatic Upgrades.
// The repo channel used must be `stable/cloud` which has the available packages for the Cloud Customer's agents.
// It pins the teleport version to the one specified by https://updates.releases.teleport.dev/v1/stable/cloud/version
// This ensures the initial installed version is the same as the `teleport-ent-updater` would install.
9340eab to
b5bdd86
Compare
Yes 👍 |
marcoandredinis
force-pushed
the
marco/auto_upgrade_script_fix_stablecloud
branch
2 times, most recently
from
a02e298 to
a84d9c6
Compare
|
With auto upgrades on And Server reporting version 14-dev I got the expected channel and version: |
|
After disabling automatic upgrades for my tenant, I get the following script Working as expected 👍 |
marcoandredinis
force-pushed
the
marco/auto_upgrade_script_fix_stablecloud
branch
from
a84d9c6 to
97195ed
Compare
When Automatic Upgrades are enabled and the current installation is an enterprise build, it will install teleport using: - stable/cloud repo channel (yum, apt) - pin the version to the one present at: https://updates.releases.teleport.dev/v1/stable/cloud/version
marcoandredinis
force-pushed
the
marco/auto_upgrade_script_fix_stablecloud
branch
from
97195ed to
01a8763
Compare
public-teleport-github-review-bot
Bot
removed the request for review
from timothyb89
|
@marcoandredinis See the table below for backport results.
|
* InstallScripts: pin teleport version using ServerVersion When Automatic Upgrades are enabled and the current installation is an enterprise build, it will install teleport using: - stable/cloud repo channel (yum, apt) - pin the version to the one present at: https://updates.releases.teleport.dev/v1/stable/cloud/version * improve comments
… (#28208) * InstallScripts: pin teleport version using ServerVersion (#28149) * InstallScripts: pin teleport version using ServerVersion When Automatic Upgrades are enabled and the current installation is an enterprise build, it will install teleport using: - stable/cloud repo channel (yum, apt) - pin the version to the one present at: https://updates.releases.teleport.dev/v1/stable/cloud/version * improve comments * fix test
5 participants
When Automatic Upgrades are enabled and it is cloud, it will install teleport using:
Demo:
Running in Cloud with Auto Upgrades
I got the expected channel and version:
Running in Cloud without Auto Upgrades
An enterprise version running self-hosted with auto upgrades
Fix #28113