Skip to content

feat: add support for label expressions to k8s operator#28074

Merged
nklaassen merged 1 commit intomasterfrom
nklaassen/le-operator
Jun 22, 2023
Merged

feat: add support for label expressions to k8s operator#28074
nklaassen merged 1 commit intomasterfrom
nklaassen/le-operator

Conversation

@nklaassen
Copy link
Copy Markdown
Contributor

This is the result of running make manifests in integrations/operator to update the CRDs with the latest role spec definition, which includes label expressions.

This is the result of running `make manifests` in integrations/operator
to update the CRDs with the latest role spec definition, which includes
label expressions.
@nklaassen nklaassen marked this pull request as ready for review June 20, 2023 17:44
@github-actions github-actions Bot requested review from espadolini and tigrato June 20, 2023 17:44
Copy link
Copy Markdown
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the operator only deal with role v5? Are label expressions active in v5?

@nklaassen
Copy link
Copy Markdown
Contributor Author

Won't the operator only deal with role v5? Are label expressions active in v5?

The operator handles role v6 too, and label expressions are active all the way back to role v3

@tigrato
Copy link
Copy Markdown
Contributor

tigrato commented Jun 22, 2023

Won't the operator only deal with role v5? Are label expressions active in v5?

The operator handles role v6 too, and label expressions are active all the way back to role v3

Actually, it only handles role v5 which is compatible with v6.
This is a limitation we need to handle

@nklaassen nklaassen added this pull request to the merge queue Jun 22, 2023
Merged via the queue into master with commit 9cec75f Jun 22, 2023
@nklaassen nklaassen deleted the nklaassen/le-operator branch June 22, 2023 16:43
@public-teleport-github-review-bot
Copy link
Copy Markdown

@nklaassen See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants