[v13] Add a delete confirmation step to SyncInventory#27961
Merged
Conversation
strideynet
approved these changes
Jun 19, 2023
Contributor
Author
|
Friendly ping @nklaassen ? |
nklaassen
approved these changes
Jun 19, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #27906 to branch/v13
Add a delete confirmation step to SyncInventory, via the new
track_missing_devicesstart parameter and a sequence ofSyncInventoryMissingDevices/SyncInventoryDevices/SyncInventoryResult messages at
the end.
The delete confirmation step is meant to address eventual pagination gaps in
MDMs APIs, and the undue automatic deletions that would follow. The confirmation
takes form of an MDM API query, using the newly-added
external_idfield.The
track_missing_devicesflag allows us to cleanly replace sync modes,on_missing actions and the external_sync_successful toggle with a single stroke.
The price to be paid is the extra
external_idstorage and a few more messagesbetween the MDM service and Auth - a negligible price most of the time.
Deprecated fields are used in e/, so they can't be deleted right away.
https://github.com/gravitational/teleport.e/issues/826