[v13] feat: adds motd to the ui#27922
Merged
r0mant merged 6 commits intobranch/v13from Jun 22, 2023
Merged
Conversation
- update MOTD to Motd - moved motd state to useLogin - added behaviour tests
… address motd warning
- add unmount test - remove motd title - group states together in useLogin - update arrow func to classic js func
ryanclark
approved these changes
Jun 16, 2023
kimlisa
approved these changes
Jun 16, 2023
Collaborator
|
Noticed one small issue. We're not properly respecting whitespace and multiline MOTD. 
Let's hold off on backports until we fix this. |
zmb3
requested changes
Jun 16, 2023
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Let's fix multiline MOTD before merging.
This was referenced Jun 16, 2023
zmb3
approved these changes
Jun 22, 2023
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
We can release this and add multiline support in a follow up.
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #27813 to branch/v13