[v13] Omit empty fields from DeviceCredential resources#27869
Merged
codingllama merged 3 commits intobranch/v13from Jun 14, 2023
Merged
[v13] Omit empty fields from DeviceCredential resources#27869codingllama merged 3 commits intobranch/v13from
codingllama merged 3 commits intobranch/v13from
Conversation
strideynet
approved these changes
Jun 14, 2023
avatus
approved these changes
Jun 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #27821 to branch/v13
Omits, from the resource representation of devices, fields that are always empty
in some cases.
DeviceAttestationTypeis particular in the sense that it tends to show up as"unspecified", while other enums are never unspecified in valid devices (OSType,
EnrollStatus), or tend to have their entire parent message/struct nil when they
would be unspecified (DeviceOrigin).
-before/+after:
https://github.com/gravitational/teleport.e/issues/827