[v12] fix: Observe accurate backend_read_seconds duration#27858
Merged
codingllama merged 2 commits intobranch/v12from Jun 14, 2023
Merged
[v12] fix: Observe accurate backend_read_seconds duration#27858codingllama merged 2 commits intobranch/v12from
backend_read_seconds duration#27858codingllama merged 2 commits intobranch/v12from
Conversation
espadolini
approved these changes
Jun 14, 2023
rosstimothy
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #27848 to branch/v12
The
backend_read_secondsmetric is not accounting for the read itself, thisfixes that. Additionally, we now use the same clock to determine start and end
times.