[v13] [Assist] New UI & rewrite#27791
Merged
ryanclark merged 2 commits intobranch/v13from Jun 15, 2023
Merged
Conversation
* Rewrite Assist & implement a new UI * Use the node name from the API * Code review comments * Address UI code review comments * Add some tests for the service * Rename "MiniAssit" to "Assist" * Impose a max height for the floating assist for small windows * Add missing license header * Update web/packages/teleport/src/Assist/Conversation/ExecuteRemoteCommandEntry.tsx Co-authored-by: Lisa Kim <lisa@goteleport.com> * Code review improvements * Only use stopPropagation so links still work and assist does not close * Make errors only show when error message isn't null * Add websocket refresh to avoid session expirations * Mark the conversation as not streaming when assist returns a full message * Improvements to error handling and icon spacing * Use encodeChallengeResponse to match the MFA backend changes * Run prettier * Usability improvements --------- Co-authored-by: Lisa Kim <lisa@goteleport.com>
|
@ryanclark - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
justinas
approved these changes
Jun 13, 2023
kimlisa
approved these changes
Jun 13, 2023
zmb3
approved these changes
Jun 14, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #27629 to branch/v13.