-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Make devbox sandbox friendly, add devbox CI. #27728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Check Devbox | ||
| run-name: Check Devbox - ${{ github.run_id }} - @${{ github.actor }} | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - 'devbox.json' | ||
| - 'devbox.lock' | ||
| - 'build.assets/flake/**' | ||
| merge_group: | ||
| paths-ignore: | ||
| - 'devbox.json' | ||
| - 'devbox.lock' | ||
| - 'build.assets/flake/**' | ||
|
|
||
| jobs: | ||
| check-devbox: | ||
| if: ${{ !startsWith(github.head_ref, 'dependabot/') }} | ||
| name: Check Devbox | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| contents: none | ||
|
|
||
| steps: | ||
| - run: 'echo "No changes to verify"' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: Check Devbox | ||
| run-name: Check Devbox - ${{ github.run_id }} - @${{ github.actor }} | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'devbox.json' | ||
| - 'devbox.lock' | ||
| - 'build.assets/flake/**' | ||
| merge_group: | ||
| paths: | ||
| - 'devbox.json' | ||
| - 'devbox.lock' | ||
| - 'build.assets/flake/**' | ||
|
|
||
| jobs: | ||
| check-devbox: | ||
| if: ${{ !startsWith(github.head_ref, 'dependabot/') }} | ||
| name: Check Devbox | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Install devbox | ||
| run: curl -fsSL https://get.jetpack.io/devbox | FORCE=1 bash | ||
|
|
||
| - name: Install devbox dependencies | ||
| run: | | ||
| devbox install | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 🎉 🎉 In case you want to enable caching in the future, you can use https://github.com/marketplace/actions/devbox-installer or copy the yaml there |
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do the
curl | bashbefore we checkout (to descope source code)?I'm thinking about attacks like https://about.codecov.io/security-update/ here.
I'm also somewhat amused that we're using a floating version of devbox, when the entire point of the tool is to pin the toolchain to specific known versions. We should probably pin the devbox version too. 😄