Skip to content

Expand Docker installation instructions#27211

Merged
ptgott merged 5 commits intomasterfrom
paul.gottschling/2023-06-01-docker
Jun 28, 2023
Merged

Expand Docker installation instructions#27211
ptgott merged 5 commits intomasterfrom
paul.gottschling/2023-06-01-docker

Conversation

@ptgott
Copy link
Copy Markdown
Contributor

@ptgott ptgott commented Jun 1, 2023

Closes #27186

Our attempt to simplify the getting started experience (#25415) condensed all getting started instructions into the Linux Server guide. This removed the only example in the docs for running Teleport on Docker. Our Installation page's Docker instructions contain only a list of supported images.

This change expands our Installation guide to provide more comprehensive instructions for running Teleport on Docker, including information on ports and file mounts as well as an example of running a Teleport container.

This also breaks up the image tables. This lets us share descriptive text between Enterprise and OSS tabs, and makes the information easier to read.

@ptgott ptgott force-pushed the paul.gottschling/2023-06-01-docker branch from 1930189 to 8fdcbcd Compare June 1, 2023 16:12
Comment thread docs/pages/installation.mdx Outdated
Comment thread docs/pages/installation.mdx Outdated
example, if you want to pull the ARM64 image for
`public.ecr.aws/gravitational/teleport`, you can use
`public.ecr.aws/gravitational/teleport:(=teleport.version=)-arm64`. Architecture
suffixes are not available for `*-distroless` or `*-distroless-debug` images.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? Are these multiarch images?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes—specified

Comment thread docs/pages/installation.mdx Outdated

#### Nightly image builds

Nightly images point to the latest version of Teleport. They are stable, and we
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with these.

Why are these called nighty? Do we rebuild them every night? If so, do we really recommend that?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text was from the original, so I'm not 100% sure of the context. From the ECR gallery, it looks like all images are pushed daily. I've suggested condensing the two subsections related to specifying the image's version.

@ptgott ptgott requested a review from zmb3 June 2, 2023 14:54
Comment thread docs/pages/installation.mdx
@ptgott ptgott requested a review from stevenGravy June 6, 2023 20:53
Comment thread docs/pages/installation.mdx Outdated
Comment thread docs/pages/installation.mdx Outdated
Comment thread docs/pages/installation.mdx Outdated
@ptgott ptgott requested a review from alexfornuto June 20, 2023 21:05
@ptgott
Copy link
Copy Markdown
Contributor Author

ptgott commented Jun 20, 2023

@stevenGravy This is ready for another look when you have a chance. Thanks!

Comment thread docs/pages/installation.mdx Outdated

```code
$ curl --insecure https://localhost:3080/webapi/ping
{"auth":{"type":"local","second_factor":"otp","preferred_local_mfa":"otp","local":{"name":""},"private_key_policy":"none","device_trust_disabled":true,"has_motd":false},"proxy":{"kube":{"enabled":true,"listen_addr":"0.0.0.0:3080"},"ssh":{"listen_addr":"0.0.0.0:3080","tunnel_listen_addr":"0.0.0.0:3080","web_listen_addr":"0.0.0.0:3080"},"db":{"postgres_listen_addr":"0.0.0.0:3080","mysql_listen_addr":"0.0.0.0:3080"},"tls_routing_enabled":true},"server_version":"12.1.5","min_client_version":"11.0.0","cluster_name":"localhost","automatic_upgrades":false}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the teleport variable so the server version stays current

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's as important here since this is example output and doesn't need to match what the user sees.

@ptgott
Copy link
Copy Markdown
Contributor Author

ptgott commented Jun 26, 2023

@alexfornuto Following up on this one, thanks!

Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits, but generally 👍

$ docker run --hostname localhost --name teleport \
-v ~/teleport/config:/etc/teleport \
-v ~/teleport/data:/var/lib/teleport \
-p 3025:3025 -p 3080:3080 \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to update this to use the standard port 443 for the web interface?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This led to an error on my Macbook that I didn't get with port 3080 (possibly due to port privileges or curl internals?):

curl --insecure https://localhost:443/webapi/ping
curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to localhost:443

Comment thread docs/pages/installation.mdx Outdated
ptgott added 5 commits June 28, 2023 16:38
Closes #27186

Our attempt to simplify the getting started experience (#25415)
condensed all getting started instructions into the Linux Server guide.
This removed the only example in the docs for running Teleport on
Docker. Our Installation page's Docker instructions contain only a list
of supported images.

This change expands our Installation guide to provide more comprehensive
instructions for running Teleport on Docker, including information on
ports and file mounts as well as an example of running a Teleport
container.

This also breaks up the image tables. This lets us share descriptive
text between Enterprise and OSS tabs, and makes the information easier
to read.
Add more context on the intended scope of the example.
@ptgott ptgott enabled auto-merge June 28, 2023 20:38
@ptgott ptgott force-pushed the paul.gottschling/2023-06-01-docker branch from cdcca34 to 6779cd6 Compare June 28, 2023 20:38
@ptgott ptgott added this pull request to the merge queue Jun 28, 2023
Merged via the queue into master with commit d76c7cb Jun 28, 2023
@ptgott ptgott deleted the paul.gottschling/2023-06-01-docker branch June 28, 2023 21:07
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ptgott See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide local Docker instructions earlier in a user's getting started experience

4 participants