[3.2] Wrap transport when kube proxy runs in-cluster. #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
reviewed
May 14, 2019
lib/kube/proxy/forwarder.go
Outdated
| // as the proxy uses client cert auth to reach out to remote proxy | ||
| // which will then use its own transport wrapper | ||
| if !ctx.cluster.isRemote { | ||
| if f.creds.cfg.WrapTransport != nil { |
There was a problem hiding this comment.
those two ifs could be just one if? if !ctx.cluster.isRemote && f.creds.cfg.WrapTransport != nil
r0mant
force-pushed
the
roman/3.2/kubeproxy
branch
from
dc80f80 to
0a1d87c
Compare
klizhentas
approved these changes
May 15, 2019
|
retest this please |
r0mant
added a commit
that referenced
this pull request
May 15, 2019
r0mant
added a commit
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with Teleport's Kubernetes proxy sending empty credentials to the API server when running in-cluster.
When Teleport runs inside Kubernetes cluster, it uses "in-cluster configuration" which provides a wrapper for transport that adds service account token to requests. This wrapper was not used and thus Teleport was not providing any credentials when making impersonation requests to the API server, which could be seen in the audit log - the "user" field was empty.
I've tested both local and remote cluster paths using Gravity (i.e. via Ops Center + cluster).