Skip to content

Fix headless server access requests#27136

Merged
Joerger merged 2 commits intomasterfrom
joerger/fix-headless-with-access-requests
Jun 1, 2023
Merged

Fix headless server access requests#27136
Joerger merged 2 commits intomasterfrom
joerger/fix-headless-with-access-requests

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented May 31, 2023

Closes #25341

@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 31, 2023
@github-actions github-actions Bot requested review from strideynet and tigrato May 31, 2023 01:24
Joerger
Joerger commented May 31, 2023
View reviewed changes
Comment thread tool/tsh/tsh.go Outdated
Comment on lines 4331 to 4334
Copy link
Copy Markdown
Contributor Author

@Joerger Joerger May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that identity files are treated as an in memory store, this restriction is no longer necessary. The user's certificates will just be updated in memory to carry out that single request. This also applies to --add-keys-to-agent=only and --headless.

@Joerger Joerger force-pushed the joerger/fix-headless-with-access-requests branch from 8d5f3ce to f69d627 Compare May 31, 2023 17:42
@Joerger Joerger enabled auto-merge May 31, 2023 17:56
@Joerger
Copy link
Copy Markdown
Contributor Author

Joerger commented May 31, 2023 •
edited
Loading

@tigrato @strideynet TestSSHHeadless was taking > 6 seconds, which causes it to fail to the flaky test detector. I made some basic refactors and split up the tests to speed it up. Please give a quick re-review.

Edit: I'm looking into the failed unit tests. -- Fixed

@Joerger Joerger requested review from strideynet and tigrato May 31, 2023 20:41
@Joerger Joerger force-pushed the joerger/fix-headless-with-access-requests branch from 582bca3 to 5b5d10c Compare June 1, 2023 00:33
tigrato
tigrato reviewed Jun 1, 2023
View reviewed changes
Comment thread tool/tsh/tsh_test.go Outdated
@Joerger Joerger force-pushed the joerger/fix-headless-with-access-requests branch from 5b5d10c to f4635f2 Compare June 1, 2023 17:28
@Joerger Joerger force-pushed the joerger/fix-headless-with-access-requests branch from 0ccfbf4 to a79dc18 Compare June 1, 2023 17:31
@Joerger Joerger force-pushed the joerger/fix-headless-with-access-requests branch from a79dc18 to 6f0a899 Compare June 1, 2023 17:32
@Joerger Joerger added this pull request to the merge queue Jun 1, 2023
Merged via the queue into master with commit a9823bf Jun 1, 2023
@Joerger Joerger deleted the joerger/fix-headless-with-access-requests branch June 1, 2023 18:25
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Jun 1, 2023

@Joerger See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR

This was referenced Jun 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigrato tigrato tigrato approved these changes

@strideynet strideynet Awaiting requested review from strideynet

Assignees

No one assigned

Labels

size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Access requests should work in conjunction with tsh --headless

3 participants

@Joerger @tigrato @strideynet