[v11] Clean up LDAP error handling#26982
Merged
zmb3 merged 1 commit intobranch/v11from May 27, 2023
Merged
Conversation
The following error often confuses users:
*ldap.Error LDAP Result Code 1 "Operations Error": 000004DC: LdapErr: DSID-0C090ACD,
comment: In order to perform this operation a successful bind must be completed on the connection.
Since Teleport always uses x509 certs to bind, this error indicates
that the Teleport-issued cert is not trusted (which is likely due to
Teleport's CA not being imported as a trusted root).
While fixing this, unify the LDAP error handling with a common
utility for converting between LDAP error codes and trace errors.
smallinsky
approved these changes
May 26, 2023
ibeckermayer
approved these changes
May 26, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #26875 to branch/v11