Skip to content

[v13] app access: improve error logging #26869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zmb3 merged 1 commit into from
May 24, 2023
Merged

[v13] app access: improve error logging #26869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/srv/app/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
err = s.serveHTTP(w, r)
}
if err != nil {
s.log.Warnf("Failed to serve request: %v.", err)
s.log.WithError(err).Warnf("Failed to serve request")

// Covert trace error type to HTTP and write response, make sure we close the
// connection afterwards so that the monitor is recreated if needed.
Expand Down Expand Up @@ -958,6 +958,7 @@ func (s *Server) authorizeContext(ctx context.Context) (*authz.Context, types.Ap
state,
matchers...)
if err != nil {
s.log.WithError(err).Warnf("access denied to application %v", app.GetName())
return nil, nil, utils.OpaqueAccessDenied(err)
}

Expand Down