athena audit logs - use otel traces in querier#26826
Merged
tobiaszheller merged 4 commits intomasterfrom May 25, 2023
Merged
Conversation
github-actions
Bot
added
audit-log
rosstimothy
reviewed
May 24, 2023
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
If you wanted to further extend tracing to the aws client we could leverage otelaws
timothyb89
approved these changes
May 25, 2023
Contributor
Author
|
@gabrielcorado @rosstimothy friendly ping, PTAL :) |
rosstimothy
approved these changes
May 25, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from gabrielcorado
|
@tobiaszheller See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/gravitational/teleport.e/issues/894
RFD: https://github.com/gravitational/teleport/blob/master/rfd/0118-scalable-audit-logs.md
Since we have ctx now in Seach interface propagated, we can use tracing in athena logger.