[v12] protobuf changes in preparation for buf breaking#26794
Merged
espadolini merged 3 commits intobranch/v12from May 26, 2023
Merged
[v12] protobuf changes in preparation for buf breaking#26794espadolini merged 3 commits intobranch/v12from
buf breaking#26794espadolini merged 3 commits intobranch/v12from
Conversation
espadolini
force-pushed
the
espadolini/proto-unbreak/v12
branch
2 times, most recently
from
24e2a70 to
4d9af33
Compare
github-actions
Bot
added
application-access
backport
database-access
github-actions
Bot
requested review from
codingllama,
r0mant,
rosstimothy,
tigrato,
timothyb89 and
zmb3
espadolini
removed
documentation
kubernetes-access
tsh
espadolini
force-pushed
the
espadolini/proto-unbreak/v12
branch
from
4d9af33 to
384002e
Compare
rosstimothy
approved these changes
May 26, 2023
codingllama
approved these changes
May 26, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this.
public-teleport-github-review-bot
Bot
removed request for
r0mant,
tigrato,
timothyb89 and
zmb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #26792