[v13] Windows TPM enrollment support (#25801)#26736
Merged
strideynet merged 1 commit intobranch/v13from May 23, 2023
Merged
Conversation
* Start implementation of Windows TPM enrollment * Basic device data collection for windows * Add AK get/creatiom * Add helpers for converting tpm protos * Don't create AK in inappropriate circumstances * Furhter simplify AK load/create * Add tests for proto/attest conversions * Ensure that digestalg varies between test cases * More accurate proto field name * Missing license header * Add credential fingerprinting function * Add getDeviceCredential implementation for windows * Add dependencies so this builds * Fix generation of credential id * Introduce AKPublic field * Collect other key data * Add some additional debug logging * Add more specific serial number fields to dcd * Use faster powershell call for determining OS version * Fix missing field in DeviceFromResource * Add link to to-do issue * Add packages necessary for enterprise submodule * Fix import orders * bump go-tpm-tools to latest versions * Tidy up returned errors * Add failure case test for Linux enrollment * move linux device fake to lib/devicetrust/testenv * Add test to exercise `RunCeremony` * Tidier assertion messages Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Further simplifcations of test assertions/errors Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Apply suggestions from code review Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Further fixes as per the llama's suggestions * Further simplification and header on logs * Use BadParameter rather than platform unsupported * Add further notes on RSAness of `go-attestation` * Minor adjustments to comments * Unused import removed * License headers * rename `mustRandomBytes` -> `randomBytes` --------- Co-authored-by: Alan Parra <alan.parra@goteleport.com>
strideynet
changed the title
codingllama
approved these changes
May 22, 2023
avatus
approved these changes
May 23, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #25801