Improve Kubernetes access test coverage#26657
Merged
Conversation
tigrato
force-pushed
the
tigrato/improve-kube-test-coverage
branch
from
33b04cb to
6c3be92
Compare
r0mant
reviewed
May 22, 2023
This PR improves the Kubernetes Access test coverage from 61% to >73%. There are some other code paths that require special attention such as watching with filtering but those require more work.
tigrato
force-pushed
the
tigrato/improve-kube-test-coverage
branch
from
cefb620 to
1482f5a
Compare
tigrato
force-pushed
the
tigrato/improve-kube-test-coverage
branch
from
1482f5a to
ebe00c6
Compare
r0mant
approved these changes
May 24, 2023
mdwn
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Kubernetes Access test coverage from 61% to >73%.
There are some other code paths that require special attention such as watching with filtering but those require more work.