helm: Fail to install if clusterName contains a colon#26615
Merged
helm: Fail to install if clusterName contains a colon#26615
clusterName contains a colon#26615Conversation
hugoShaka
approved these changes
May 19, 2023
Contributor
|
Can we also backport it to v12? :) |
Contributor
Author
|
I don't see why not! |
tigrato
approved these changes
May 19, 2023
timothyb89
approved these changes
May 25, 2023
public-teleport-github-review-bot
Bot
removed request for
klizhentas,
r0mant and
zmb3
|
@webvictim See the table below for backport results.
|
This was referenced May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A discussion on the community slack showed me that a user was specifying
clusterName: teleport.example.com:443in their values. This works, weirdly, but breaks the templating of the cluster's public address and causestsh app config,tsh app loginand associatedcurlcommands to fail on v13.The reason is that the user thought they needed to specify
:443on the end of theclusterNamefor their load balancer. This seems like a simple footgun we can encourage people to avoid.