Don't unmount cgroup2 when restarting#26610
Merged
espadolini merged 2 commits intomasterfrom May 22, 2023
Merged
Conversation
github-actions
Bot
added
bpf
zmb3
approved these changes
May 19, 2023
Contributor
Author
|
Waiting for a customer to confirm that the dev build with this change fixes their problem. |
jakule
reviewed
May 19, 2023
Contributor
jakule
left a comment
jakule
left a comment
There was a problem hiding this comment.
@espadolini Why will we leave the cgroup instead of re-creating it if it doesn't exist?
Contributor
Author
|
I don't see how that could be done sanely, since we don't really know when the old instance of teleport will get around to unmounting the hierarchy; even the very silly option of attempting to mount the file system on every cgroup interaction is racy like that. I suspect that the actual solution is to simply never unmount the filesystem, to be honest. |
lxea
approved these changes
May 22, 2023
jakule
approved these changes
May 22, 2023
rosstimothy
approved these changes
May 22, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
|
@espadolini See the table below for backport results.
|
This was referenced May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so that we don't unmount the
cgroup2filesystem if Teleport is restarting (either in-process or via SIGHUP into another process), since the new Teleport might've already checked that the mount point is in place, and will be responsible for cleaning it up in the future.Fixes #26273.