Conversation
- Remove the Teleport Enterprise Cloud Getting Started guide, since this assumes that you have signed up for an Enterprise Cloud trial. Instead, users will sign up for a Team trial to add their first resource and follow a new guide to using Teleport Team. - Move references to Teleport Team first in lists of Teleport editions, since this is the intended first step for self-service users.
- Update screenshots - Move Docker instructions to a Details box and make Docker optional, with the idea that Linux and macOS users could join their workstations to their Teleport cluster.
In this test environment, there was no support for ARM on macOS. Requiring a container ensures consistency between environments.
xinding33
approved these changes
May 19, 2023
alexfornuto
reviewed
May 19, 2023
| Teleport Team makes it easier for small organizations to get started with | ||
| enabling secure access to their infrastructure. It includes a subset of Teleport | ||
| Enterprise Cloud features, and teams can switch to Teleport Enterprise Cloud | ||
| as they scale up their Teleport usage. |
Contributor
There was a problem hiding this comment.
Alternate option.
Suggested change
| as they scale up their Teleport usage. | |
| as they scale up their infrastructure. |
Since it's their own environment that will scale, and Teleport scales with it..
Contributor
Author
There was a problem hiding this comment.
Ah, nice. I'll change to "scale up" in general, since it can imply adding users
Comment on lines
+95
to
+97
| The rest of the guide assumes that you will run it as a non-`root` user, but the | ||
| shell in the container you created earlier is running as root. Alias `sudo` to | ||
| override this: |
Contributor
There was a problem hiding this comment.
This sounds odd to me. If it's "the guide" which we wrote, then we could write it to not use sudo. Instead, can we rephrase this to say that the Teleport web UI provides example commands assuming a non-root user?
Contributor
Author
There was a problem hiding this comment.
To make this clearer/simpler, I've moved this text just before the instructions to copy the installation script:
The Teleport installation script uses `sudo`, which is not installed on your
Docker container. Alias `sudo` in your container terminal to override this:
```code
$ alias sudo=""
```
Copy the script and paste it into the shell you opened earlier on your Docker
container.
alexfornuto
approved these changes
May 19, 2023
ptgott
added a commit
that referenced
this pull request
May 19, 2023
Backports #26523 * Add documentation for Teleport Team - Remove the Teleport Enterprise Cloud Getting Started guide, since this assumes that you have signed up for an Enterprise Cloud trial. Instead, users will sign up for a Team trial to add their first resource and follow a new guide to using Teleport Team. - Move references to Teleport Team first in lists of Teleport editions, since this is the intended first step for self-service users. * Update the Teleport Team guide - Update screenshots - Move Docker instructions to a Details box and make Docker optional, with the idea that Linux and macOS users could join their workstations to their Teleport cluster. * Require a Docker container again In this test environment, there was no support for ARM on macOS. Requiring a container ensures consistency between environments. * Add a diagram * Fix links * Linter fixes * Respond to alexfornuto feedback
ptgott
added a commit
that referenced
this pull request
May 22, 2023
Backports #26523 * Add documentation for Teleport Team - Remove the Teleport Enterprise Cloud Getting Started guide, since this assumes that you have signed up for an Enterprise Cloud trial. Instead, users will sign up for a Team trial to add their first resource and follow a new guide to using Teleport Team. - Move references to Teleport Team first in lists of Teleport editions, since this is the intended first step for self-service users. * Update the Teleport Team guide - Update screenshots - Move Docker instructions to a Details box and make Docker optional, with the idea that Linux and macOS users could join their workstations to their Teleport cluster. * Require a Docker container again In this test environment, there was no support for ARM on macOS. Requiring a container ensures consistency between environments. * Add a diagram * Fix links * Linter fixes * Respond to alexfornuto feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.