Skip to content

Add RoleInstance to TestLocalServiceRolesHavePermissionsForUploaderService#26516

Merged
codingllama merged 1 commit intomasterfrom
codingllama/uploader-roleinstance
May 19, 2023
Merged

Add RoleInstance to TestLocalServiceRolesHavePermissionsForUploaderService#26516
codingllama merged 1 commit intomasterfrom
codingllama/uploader-roleinstance

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

@codingllama codingllama commented May 18, 2023 •
edited
Loading

Make sure RoleInstance has uploader permissions.

@codingllama codingllama requested a review from zmb3 May 18, 2023 18:02
@github-actions github-actions Bot requested review from mdwn and probakowski May 18, 2023 18:03
zmb3
zmb3 approved these changes May 18, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks llama!

@codingllama
Copy link
Copy Markdown
Contributor Author

codingllama commented May 19, 2023

Friendly ping @mdwn @probakowski ?

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from probakowski May 19, 2023 13:40
@codingllama
Copy link
Copy Markdown
Contributor Author

codingllama commented May 19, 2023

Thanks, folks.

@codingllama codingllama added this pull request to the merge queue May 19, 2023
Merged via the queue into master with commit f0ad59a May 19, 2023
@codingllama codingllama deleted the codingllama/uploader-roleinstance branch May 19, 2023 14:00
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented May 19, 2023

@codingllama See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Failed
branch/v13 Create PR

@codingllama codingllama mentioned this pull request May 19, 2023
Merged
codingllama added a commit that referenced this pull request May 19, 2023
@codingllama
Add RoleInstance to TestLocalServiceRolesHavePermissionsForUploaderSe…
8831f3c 
…rvice (#26516)
codingllama added a commit that referenced this pull request May 19, 2023
@codingllama
Add RoleInstance to TestLocalServiceRolesHavePermissionsForUploaderSe…
ca59430 
…rvice (#26516)
This was referenced May 19, 2023
Merged
Merged
codingllama added a commit that referenced this pull request May 19, 2023
@codingllama
[v11] Add RoleInstance to TestLocalServiceRolesHavePermissionsForUplo…
8bd3a11 
…aderService (#26608)

* Add RoleInstance to TestLocalServiceRolesHavePermissionsForUploaderService (#26516)

* Fixes for `authz` package
codingllama added a commit that referenced this pull request May 19, 2023
@codingllama
Add RoleInstance to TestLocalServiceRolesHavePermissionsForUploaderSe…
201dbca 
…rvice (#26516) (#26609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@probakowski probakowski probakowski approved these changes

@zmb3 zmb3 zmb3 approved these changes

+1 more reviewer

@mdwn mdwn mdwn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codingllama @mdwn @probakowski @zmb3