athena audit logs - sent checksum on s3 write#26511
Merged
tobiaszheller merged 1 commit intomasterfrom May 23, 2023
Merged
Conversation
github-actions
Bot
added
audit-log
Contributor
Author
|
Done |
tobiaszheller
force-pushed
the
tobiaszheller/auditevents-athena-checksum-on-s3-put
branch
from
7d4b2ab to
e739874
Compare
tobiaszheller
force-pushed
the
tobiaszheller/auditevents-athena-checksum-on-s3-put
branch
from
e739874 to
49ca2b3
Compare
tobiaszheller
force-pushed
the
tobiaszheller/auditevents-athena-checksum-on-s3-put
branch
from
49ca2b3 to
becbcef
Compare
Contributor
Author
|
@gzdunek @rosstimothy it is ready for review now |
rosstimothy
approved these changes
May 22, 2023
lxea
approved these changes
May 23, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
tobiaszheller
deleted the
tobiaszheller/auditevents-athena-checksum-on-s3-put
branch
|
@tobiaszheller See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/gravitational/teleport.e/issues/894
RFD: https://github.com/gravitational/teleport/blob/master/rfd/0118-scalable-audit-logs.md
When using object locking on s3 bucket, checksum of file needs to be calculated when sending it to aws. SDK does it out of the box, just configuration needs to be provided.