skip rdpclient build in integration tests#26492
Merged
GavinFrazar merged 2 commits intomasterfrom May 18, 2023
Merged
Conversation
GavinFrazar
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
tigrato
approved these changes
May 18, 2023
zmb3
approved these changes
May 18, 2023
public-teleport-github-review-bot
Bot
removed request for
ibeckermayer and
timothyb89
GavinFrazar
deleted the
gavinfrazar/skip-rdpclient-build-in-integration-tests
branch
GavinFrazar
added a commit
that referenced
this pull request
May 18, 2023
backport #26492 to branch/v13. * add RDPCLIENT_SKIP_BUILD opt to makefile * skip rdpclient build in go integration tests
GavinFrazar
added a commit
that referenced
this pull request
May 18, 2023
backport #26492 to branch/v12. * add RDPCLIENT_SKIP_BUILD opt to makefile * skip rdpclient build in go integration tests
GavinFrazar
added a commit
that referenced
this pull request
May 18, 2023
backport #26492 to branch/v11. * add RDPCLIENT_SKIP_BUILD opt to makefile * skip rdpclient build in go integration tests
GavinFrazar
added a commit
that referenced
this pull request
May 25, 2023
backport #26492 to branch/v13. * add RDPCLIENT_SKIP_BUILD opt to makefile * skip rdpclient build in go integration tests
GavinFrazar
added a commit
that referenced
this pull request
May 25, 2023
backport #26492 to branch/v11. * add RDPCLIENT_SKIP_BUILD opt to makefile * skip rdpclient build in go integration tests
GavinFrazar
added a commit
that referenced
this pull request
May 25, 2023
backport #26492 to branch/v12. * add RDPCLIENT_SKIP_BUILD opt to makefile * skip rdpclient build in go integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
RDPCLIENT_SKIP_BUILDvar to the makefile and skips building the rust windows RDP client before running go integration tests in CI, since they do not depend on the rdpclient.I had to add the option to skip it since otherwise the makefile by default adds the rdp build tag which leads to a link error if it's not built.