Do not run the uploader with the MDM role#26491
Merged
codingllama merged 4 commits intomasterfrom May 18, 2023
Merged
Conversation
codingllama
commented
May 17, 2023
smallinsky
reviewed
May 18, 2023
codingllama
force-pushed
the
codingllama/dt-uploader
branch
from
f6fb029 to
18ad2f3
Compare
Contributor
Author
|
PTAL? |
smallinsky
approved these changes
May 18, 2023
smallinsky
approved these changes
May 18, 2023
zmb3
reviewed
May 18, 2023
codingllama
force-pushed
the
codingllama/dt-uploader
branch
from
18ad2f3 to
9ae7d77
Compare
Contributor
Author
|
PTAL @zmb3 ? |
zmb3
approved these changes
May 18, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from atburke
|
@codingllama See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not run the uploader with the MDM role, MDM service instances don't have the necessary permissions to write events.
Follow up from #26395.
https://github.com/gravitational/teleport.e/issues/826