Define the "jamf_service" configuration#26478
Merged
codingllama merged 6 commits intomasterfrom May 22, 2023
Merged
Conversation
codingllama
changed the title
codingllama
force-pushed
the
codingllama/dt-jamfcfg
branch
from
9c86b0d to
d0f4bbb
Compare
mdwn
approved these changes
May 18, 2023
Contributor
mdwn
left a comment
mdwn
left a comment
There was a problem hiding this comment.
Overall LGTM, just one question w/r/t the time.Duration pointers.
codingllama
force-pushed
the
codingllama/dt-jamfcfg
branch
3 times, most recently
from
fb04687 to
b3c6215
Compare
Contributor
Author
|
Friendly ping @strideynet @hugoShaka @probakowski ? |
hugoShaka
approved these changes
May 19, 2023
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
Sorry for the delay.
The RFD-7e is extremely clear and detailed. It gives all the context needed for the review. Thank you, this really helps :)
Contributor
Author
|
Thanks for the kind words, Hugo. |
codingllama
force-pushed
the
codingllama/dt-jamfcfg
branch
from
b3c6215 to
78d6325
Compare
strideynet
approved these changes
May 22, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from probakowski
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
May 22, 2023
* Add Jamf configuration to `servicecfg` * Add Jamf to enterpriseServicesEnabled() * Add JamfSpecV1 validation * Add jamf_service to fileconf * Add godoc to constants * Use non-pointer durations
codingllama
added a commit
that referenced
this pull request
May 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the "jamf_service" stanza to fileconf and the corresponding entry to
servicecfg.Changes on
servicecfg,enterpriseServicesEnabledandApplyFileConfigare part of the groundwork for the Jamf MDM service, as is the configuration itself.https://github.com/gravitational/teleport.e/issues/826