Skip to content

auditlog - pass context and rework search params#26433

Merged
tobiaszheller merged 6 commits intomasterfrom
tobiaszheller/auditlog-pass-ctx
May 19, 2023
Merged

auditlog - pass context and rework search params#26433
tobiaszheller merged 6 commits intomasterfrom
tobiaszheller/auditlog-pass-ctx

Conversation

@tobiaszheller
Copy link
Copy Markdown
Contributor

@tobiaszheller tobiaszheller commented May 17, 2023

This PR does two things:

  • passes context to SearchEvents and SearchSessionEvents calls
  • reworks input params to search endpoints to use struct instead of 8/10 params: 87a7b76.

EnterprisePR: https://github.com/gravitational/teleport.e/pull/1423

@tobiaszheller tobiaszheller force-pushed the tobiaszheller/auditlog-pass-ctx branch from fceb64d to a4de9bf Compare May 17, 2023 12:21
@tobiaszheller tobiaszheller force-pushed the tobiaszheller/auditlog-pass-ctx branch from a4de9bf to c71c06c Compare May 17, 2023 12:27
@tobiaszheller tobiaszheller requested review from espadolini and zmb3 May 17, 2023 12:29
@tobiaszheller
Copy link
Copy Markdown
Contributor Author

@zmb3 @espadolini I would like to get your opinion first just on 87a7b76

Copy link
Copy Markdown
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it.

Comment thread lib/events/api.go Outdated
Comment thread lib/events/api.go Outdated
@tobiaszheller tobiaszheller marked this pull request as ready for review May 17, 2023 15:15
@github-actions github-actions Bot requested review from strideynet and xacrimon May 17, 2023 15:15
@github-actions github-actions Bot added application-access audit-log Issues related to Teleports Audit Log size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 17, 2023
@espadolini
Copy link
Copy Markdown
Contributor

espadolini commented May 18, 2023

Could you add OTEL traces in this PR or do you want this to be just a change in how the parameters are passed?

edit: we already create a span for the call to the GetEvents rpc, so maybe it wouldn't be that useful without actually adding traces to individual parts in each audit log driver

@tobiaszheller
Copy link
Copy Markdown
Contributor Author

Could you add OTEL traces in this PR or do you want this to be just a change in how the parameters are passed?

edit: we already create a span for the call to the GetEvents rpc, so maybe it wouldn't be that useful without actually adding traces to individual parts in each audit log driver

let's add traces in separate PR, this is already large.

@tobiaszheller tobiaszheller added this pull request to the merge queue May 19, 2023
Merged via the queue into master with commit be00c95 May 19, 2023
@tobiaszheller tobiaszheller deleted the tobiaszheller/auditlog-pass-ctx branch May 19, 2023 08:23
@public-teleport-github-review-bot
Copy link
Copy Markdown

@tobiaszheller See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application-access audit-log Issues related to Teleports Audit Log size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants