add rbac for cluster alerts#26423
Merged
fspmarshall merged 1 commit intomasterfrom May 17, 2023
Merged
Conversation
hugoShaka
approved these changes
May 17, 2023
fspmarshall
force-pushed
the
fspmarshall/alert-rbac
branch
2 times, most recently
from
4146df7 to
28c34db
Compare
rosstimothy
approved these changes
May 17, 2023
fspmarshall
force-pushed
the
fspmarshall/alert-rbac
branch
from
28c34db to
a492e04
Compare
|
@fspmarshall See the table below for backport results.
|
fspmarshall
added a commit
that referenced
this pull request
May 23, 2023
fspmarshall
added a commit
that referenced
this pull request
May 23, 2023
fspmarshall
added a commit
that referenced
this pull request
May 24, 2023
fspmarshall
added a commit
that referenced
this pull request
May 24, 2023
fspmarshall
added a commit
that referenced
this pull request
May 24, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RBAC support for cluster alerts so that the
tctl alert *family of commands can be used via remotetctl. Havingcreate/updatepermissions forcluster_alertallows crating/acknowledging alerts, and havingread/listallowstctl alerts lsto show all alerts, even if their labels don't specify the caller as the target audience.Updates the provided
editorandauditorroles to have read/write and read-only alert permissions respectively.Should be the last item to fully address #17188