include expiration in audit log lock event#26421
Merged
stevenGravy merged 9 commits intomasterfrom Dec 18, 2023
Merged
Conversation
zmb3
reviewed
May 17, 2023
zmb3
reviewed
Nov 29, 2023
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
mdwn
approved these changes
Dec 18, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from jimbishopp
|
@stevenGravy See the table below for backport results.
|
This was referenced Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a expiration was set it wasn't included in the audit log for lock create events. Currenlty it's always
"expires": "0001-01-01T00:00:00Z",Now it will set the expires as in this case when it's
2maway.0001-01-01T00:00:00Zwill show for never expires.{ "cluster_name": "teleport.example.com", "code": "TLK00I", "ei": 0, "event": "lock.created", "expires": "2023-05-17T02:18:35.44638Z", "name": "56642c1f-441b-46ae-ab4c-de4872c891f2", "target": { "role": "auditor" }, "time": "2023-05-17T02:16:35.451Z", "uid": "5343ca78-4984-49de-932c-a2a665d93cc6", "updated_by": "steven", "user": "steven" }Updated test to include a time comparison.
changelog: Lock expiration time included in Audit Log Lock Create events