Fix port forwarding when using a label based target#26394
Merged
rosstimothy merged 1 commit intomasterfrom May 22, 2023
Merged
Conversation
Label based connections that do not provide a command and open a shell for the first match were only performing a portion of the logic that non label based interactive sessions were. Instead of connecting directly to a host and opening a session, `tc.runShellOrCommandOnSingleNode` is called to achieve the same behavior as non label based connections. In addition to fixing #23261 this should also add support for `-N` in the same scenario.
rosstimothy
force-pushed
the
tross/fix_label_forwarding
branch
from
d176c01 to
4274b39
Compare
Contributor
Author
r0mant
approved these changes
May 22, 2023
kimlisa
approved these changes
May 22, 2023
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
May 22, 2023
Label based connections that do not provide a command and open a shell for the first match were only performing a portion of the logic that non label based interactive sessions were. Instead of connecting directly to a host and opening a session, `tc.runShellOrCommandOnSingleNode` is called to achieve the same behavior as non label based connections. In addition to fixing #23261 this should also add support for `-N` in the same scenario.
rosstimothy
added a commit
that referenced
this pull request
May 22, 2023
Label based connections that do not provide a command and open a shell for the first match were only performing a portion of the logic that non label based interactive sessions were. Instead of connecting directly to a host and opening a session, `tc.runShellOrCommandOnSingleNode` is called to achieve the same behavior as non label based connections. In addition to fixing #23261 this should also add support for `-N` in the same scenario.
rosstimothy
added a commit
that referenced
this pull request
May 22, 2023
Label based connections that do not provide a command and open a shell for the first match were only performing a portion of the logic that non label based interactive sessions were. Instead of connecting directly to a host and opening a session, `tc.runShellOrCommandOnSingleNode` is called to achieve the same behavior as non label based connections. In addition to fixing #23261 this should also add support for `-N` in the same scenario.
rosstimothy
added a commit
that referenced
this pull request
May 22, 2023
Label based connections that do not provide a command and open a shell for the first match were only performing a portion of the logic that non label based interactive sessions were. Instead of connecting directly to a host and opening a session, `tc.runShellOrCommandOnSingleNode` is called to achieve the same behavior as non label based connections. In addition to fixing #23261 this should also add support for `-N` in the same scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label based connections that do not provide a command and open a shell for the first match were only performing a portion of the logic that non label based interactive sessions were. Instead of connecting directly to a host and opening a session,
tc.runShellOrCommandOnSingleNodeis called to achieve the same behavior as non label based connections.In addition to fixing #23261 this should also add support for
-Nin the same scenario.