Skip to content

Add a guide to reviewing docs PRs#26393

Merged
ptgott merged 1 commit intomasterfrom
paul.gottschling/11146-review-pr
May 25, 2023
Merged

Add a guide to reviewing docs PRs#26393
ptgott merged 1 commit intomasterfrom
paul.gottschling/11146-review-pr

Conversation

@ptgott
Copy link
Copy Markdown
Contributor

@ptgott ptgott commented May 16, 2023

Closes #11146

This guide shows users who (a) may not be accustomed to contributing Teleport docs changes but (b) want to review a docs change how to spin up the dev server to preview docs changes.

Closes #11146

This guide shows users who (a) may not be accustomed to contributing
Teleport docs changes but (b) want to review a docs change how to spin
up the dev server to preview docs changes.
@alexfornuto
Copy link
Copy Markdown
Contributor

alexfornuto commented May 17, 2023

Before digging into this, what's the likelihood that we can have vercel-built preview environments linked by bots in a PR thread?

@ptgott
Copy link
Copy Markdown
Contributor Author

ptgott commented May 17, 2023

@alexfornuto Once we get preview links going, I think we can remove this page. I'm not sure when that will happen or if it will happen smoothly, so my vote is to leave this guide up in the meantime, even if we end up leaving it up for a week or two.

@ptgott ptgott added this pull request to the merge queue May 25, 2023
Merged via the queue into master with commit 7e8f43b May 25, 2023
@ptgott ptgott deleted the paul.gottschling/11146-review-pr branch May 25, 2023 16:51
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ptgott See the table below for backport results.

Branch Result
branch/v11 Create PR
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Getting Started guide for reviewing PRs

3 participants