Add the JamfSpecV1 proto#26391
Merged
codingllama merged 3 commits intomasterfrom May 17, 2023
Merged
Conversation
Contributor
Author
|
FYI @sshahcodes. |
codingllama
force-pushed
the
codingllama/dt-jamfspec
branch
from
a7f9fae to
f64246f
Compare
zmb3
approved these changes
May 16, 2023
mdwn
approved these changes
May 17, 2023
public-teleport-github-review-bot
Bot
removed request for
probakowski and
strideynet
Contributor
|
Thanks @codingllama. This will be handy replacing my test protos: #26374 |
codingllama
force-pushed
the
codingllama/dt-jamfspec
branch
from
f64246f to
8475bbc
Compare
Contributor
Author
|
Thanks for the quick reviews, folks. |
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
May 18, 2023
* Add JamfSpecV1 proto * Correction: filter_rsql is not required * Update generated protos
codingllama
added a commit
that referenced
this pull request
May 18, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JamfSpecV1 proto is the basis of the Jamf MDM Service configuration.
Added as a "types" proto so it could be reused by eventual Cloud-based setups.
Deviates from the RFD in the definition of Duration-like fields: the gogo typecasts don't allow us to distinguish zero from nil, so we are equating "zero" to "use the defaults".
Relevant sections:
https://github.com/gravitational/teleport.e/issues/826