Conversation
ibeckermayer
approved these changes
May 16, 2023
probakowski
approved these changes
May 16, 2023
public-teleport-github-review-bot
Bot
removed request for
GavinFrazar and
ryanclark
zmb3
force-pushed
the
zmb3/desktop-discovery-skip
branch
from
27d4f7d to
c3d945d
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
The sAMAccount type is always indexed, so this is a more efficient query than using the object class attribute.
If we discover LDAP entries with a mising hostname, just skip over them. This generates less noise in the logs.
Prefer a user-friendly message over "RDP Connection Failed" where possible.
zmb3
force-pushed
the
zmb3/desktop-discovery-skip
branch
from
c3d945d to
f08b185
Compare
This was referenced May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.