[v12] Update electron and electron-builder (#26072)#26334
Merged
gzdunek merged 3 commits intobranch/v12from May 17, 2023
Merged
[v12] Update electron and electron-builder (#26072)#26334gzdunek merged 3 commits intobranch/v12from
electron and electron-builder (#26072)#26334gzdunek merged 3 commits intobranch/v12from
Conversation
* Upgrade electron and electron-builder * Update the path to x64 build * Update electron to 24.3.0 * Use the latest after-install and after-remove scripts * Run prettier * Use correct indentation * Use app path in `update-alternatives --remove` (cherry picked from commit a5679de)
avatus
approved these changes
May 16, 2023
Member
|
@gzdunek Did you perhaps run a tag build for the v12 and v11 backports? They don't have universal builds AFAIR so I think it'd be worthwhile to do that. |
ravicious
approved these changes
May 17, 2023
| "@types/node" "*" | ||
|
|
||
| "@types/google-protobuf@^3.10.0", "@types/google-protobuf@^3.7.2": | ||
| "@types/google-protobuf@^3.10.0": |
Member
There was a problem hiding this comment.
I thought we have dealt with that. 🤨
Edit: After I ran yarn on my laptop on this branch, it reverted back to what this commit removes.
Contributor
Author
|
v12 build https://drone.platform.teleport.sh/gravitational/teleport/24058 - there were some failures, but unrelated to Connect. I tested dmg and didn't see any problems. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #26072 to branch/v12