Proto and Go module changes for Windows TPM support#26325
Merged
strideynet merged 6 commits intomasterfrom May 16, 2023
Merged
Conversation
ryanclark
approved these changes
May 16, 2023
smallinsky
approved these changes
May 16, 2023
public-teleport-github-review-bot
Bot
removed request for
atburke and
codingllama
|
@strideynet See the table below for backport results.
|
Contributor
|
LGTM. Thanks for splitting it up. |
strideynet
added a commit
that referenced
this pull request
May 16, 2023
* Proto and Go module changes for Windows TPM support * Obligatory `go mod tidy` && `make fix-imports` * Godocs for proto conversion methods * Move dependencies to main indirect block * Handle nil more gracefully
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting some work out from #25801 to reduce the size.
Looks like a lot of changes but it's really just some tests and some proto changes and some proto conversion funcs.