check for empty name part in role arn#26315
Merged
GavinFrazar merged 1 commit intomasterfrom May 16, 2023
Merged
Conversation
GavinFrazar
added
aws
GavinFrazar
requested review from
greedy52
and removed request for
ibeckermayer and
rosstimothy
Contributor
Author
|
huh, I clicked on a suggested reviewer at the same time as the bot added reviewers, and it removed them 🤷♂️ oh well |
smallinsky
approved these changes
May 16, 2023
greedy52
approved these changes
May 16, 2023
|
@GavinFrazar See the table below for backport results.
|
This was referenced May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue where the role arn checking doesn't check if the role name is
""(empty).We were checking if the role arn resource had at least 2 parts separated by
"/", but we didn't check if the last part is empty.strings.Split("role/", "/")) == []string{"role", ""}This was a minor inconvenience I ran into recently. Instead of catching my typo early, the db service was trying to assume the invalid role and returning a less helpful error message from the failed assume role call.