[v12] Revert usage of grpc error interceptors in lib/client#26299
Merged
rosstimothy merged 1 commit intobranch/v12from May 17, 2023
Merged
[v12] Revert usage of grpc error interceptors in lib/client#26299rosstimothy merged 1 commit intobranch/v12from
rosstimothy merged 1 commit intobranch/v12from
Conversation
The middleware for converting errors cause stack traces to lead back to the middleware instead of the proper location making logged errors less helpful. Reverting the use of the middleware from #25694 in favor of converting stream errors directly.
nklaassen
approved these changes
May 16, 2023
zmb3
approved these changes
May 16, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from camscale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #26169 to branch/v12