Fix twoClustersTunnel flakiness#26233
Merged
tobiaszheller merged 1 commit intomasterfrom May 15, 2023
Merged
Conversation
r0mant
approved these changes
May 15, 2023
marcoandredinis
approved these changes
May 15, 2023
tobiaszheller
deleted the
tobiaszheller/fix-twoClustersTunnel-flaky-with-check-before-stop
branch
|
@tobiaszheller See the table below for backport results.
|
This was referenced May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes: #26225.
Before stopping auth, we make sure that 2nd event is received.
This test was flaky before but I believe it gotten worse after explicitly closing log on process stop (
teleport/lib/auth/auth.go
Lines 1191 to 1195 in e9d397e
Node is using async emitter and if we stop auth immediately after sending exec, there is high chance that it won't be there. Adding explicit close on events log, cause it to fail more often because it's closed earlier.