Skip to content

Adds an admonition about Teleport not currently supporting Azure AD#26210

Merged
ibeckermayer merged 5 commits intomasterfrom
isaiah/azure-ad-admonition
May 18, 2023
Merged

Adds an admonition about Teleport not currently supporting Azure AD#26210
ibeckermayer merged 5 commits intomasterfrom
isaiah/azure-ad-admonition

Conversation

@ibeckermayer
Copy link
Copy Markdown
Contributor

@ibeckermayer ibeckermayer commented May 15, 2023

No description provided.

@ibeckermayer ibeckermayer requested a review from zmb3 May 15, 2023 00:00
@ibeckermayer ibeckermayer force-pushed the isaiah/azure-ad-admonition branch from d30d572 to e596d81 Compare May 15, 2023 03:35
@ibeckermayer ibeckermayer force-pushed the isaiah/azure-ad-admonition branch from e596d81 to 7825b9d Compare May 15, 2023 03:52
ptgott
ptgott reviewed May 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this Admonition also apply to docs/pages/desktop-access/active-directory-manual.mdx?

Also, can organizations that use Azure AD take advantage of the approach documented in docs/pages/desktop-access/getting-started.mdx with Teleport Enterprise? If so, maybe we can add a link to the Admonition recommending this approach?

@ibeckermayer
Copy link
Copy Markdown
Contributor Author

ibeckermayer commented May 16, 2023

Does this Admonition also apply to docs/pages/desktop-access/active-directory-manual.mdx?

Yes

Also, can organizations that use Azure AD take advantage of the approach documented in docs/pages/desktop-access/getting-started.mdx with Teleport Enterprise? If so, maybe we can add a link to the Admonition recommending this approach?

I'm pretty sure this is the case, added in cc18a66. @probakowski @zmb3 can either of you confirm this?

zmb3
zmb3 approved these changes May 17, 2023
View reviewed changes
Comment thread docs/pages/desktop-access/active-directory-manual.mdx Outdated
Comment thread docs/pages/desktop-access/active-directory.mdx Outdated
Isaiah Becker-Mayer and others added 2 commits May 18, 2023 12:55
@zmb3
Update docs/pages/desktop-access/active-directory-manual.mdx
94c4442 
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@zmb3
Update docs/pages/desktop-access/active-directory.mdx
198c00e 
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@ibeckermayer ibeckermayer enabled auto-merge May 18, 2023 19:55
@ibeckermayer ibeckermayer added this pull request to the merge queue May 18, 2023
Merged via the queue into master with commit 64deb39 May 18, 2023
@ibeckermayer ibeckermayer deleted the isaiah/azure-ad-admonition branch May 18, 2023 20:20
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented May 18, 2023

@ibeckermayer See the table below for backport results.

Branch Result
branch/v10 Failed
branch/v11 Failed
branch/v12 Create PR
branch/v13 Create PR

This was referenced May 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmb3 zmb3 zmb3 approved these changes

@ptgott ptgott ptgott approved these changes

Assignees

No one assigned

Labels

documentation size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibeckermayer @zmb3 @ptgott