Skip to content

Docs: Apply Styling to Graph#26154

Merged
alexfornuto merged 3 commits intopaul.gottschling/14485-diagramfrom
afornuto/14485-suggestions
May 16, 2023
Merged

Docs: Apply Styling to Graph#26154
alexfornuto merged 3 commits intopaul.gottschling/14485-diagramfrom
afornuto/14485-suggestions

Conversation

@alexfornuto
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto commented May 12, 2023

Suggested edits to new mermaid graph in #25887.

Before:
image

After:
image

Also removes the now-unused image.

Comment thread docs/pages/kubernetes-access/getting-started.mdx Outdated
Copy link
Copy Markdown
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits! I think removing the "Public Network" label/box makes sense, as does the bidirectional arrow.

I'm not sure I like the yellow-on-purple coloring, though, and I would rather have a consistent stylesheet that we could apply to all Mermaid graphs so docs authors wouldn't need to worry about styling.

What would you think about reverting the coloring changes but keeping the rest?

@alexfornuto
Copy link
Copy Markdown
Contributor Author

I'm not sure I like the yellow-on-purple coloring, though,

Agreed. We could always change the yellow color.

and I would rather have a consistent stylesheet that we could apply to all Mermaid graphs so docs authors wouldn't need to worry about styling.

Yes! If you like the coloring, we could add some classes to our main page style and call them in the mermaid charts. My other PR has them defined in the chart, but we could make them site-wide. In the meantime though, we can play around with the colors per guide, then standardize them once we have a master stylesheet.

What would you think about reverting the coloring changes but keeping the rest?

Sure, unless you wanna think about any of the suggestions ^.

@alexfornuto alexfornuto merged this pull request into paul.gottschling/14485-diagram May 16, 2023
@alexfornuto alexfornuto deleted the afornuto/14485-suggestions branch May 16, 2023 16:05
ptgott pushed a commit that referenced this pull request May 18, 2023
* apply styling to graph

* remove unused image
stevenGravy added a commit that referenced this pull request May 18, 2023
* Refresh Kubernetes Access Getting Started diagram

Closes #14485

- Use a Mermaid diagram instead of an image (see #25883)
- Update terms used in the diagram
- Ensure that the name of the Teleport cluster is consistent between the
  diagram and the body text

* Docs: Apply Styling to Graph (#26154)

* apply styling to graph

* remove unused image

---------

Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
Co-authored-by: Steven Martin <steven@goteleport.com>
github-actions Bot pushed a commit that referenced this pull request May 18, 2023
* apply styling to graph

* remove unused image
github-actions Bot pushed a commit that referenced this pull request May 18, 2023
* apply styling to graph

* remove unused image
github-actions Bot pushed a commit that referenced this pull request May 18, 2023
* apply styling to graph

* remove unused image
ptgott added a commit that referenced this pull request May 22, 2023
* Refresh Kubernetes Access Getting Started diagram

Closes #14485

- Use a Mermaid diagram instead of an image (see #25883)
- Update terms used in the diagram
- Ensure that the name of the Teleport cluster is consistent between the
  diagram and the body text

* Docs: Apply Styling to Graph (#26154)

* apply styling to graph

* remove unused image

---------

Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
ptgott added a commit that referenced this pull request May 22, 2023
* Refresh Kubernetes Access Getting Started diagram

Closes #14485

- Use a Mermaid diagram instead of an image (see #25883)
- Update terms used in the diagram
- Ensure that the name of the Teleport cluster is consistent between the
  diagram and the body text

* Docs: Apply Styling to Graph (#26154)

* apply styling to graph

* remove unused image

---------

Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
ptgott added a commit that referenced this pull request May 22, 2023
* Refresh Kubernetes Access Getting Started diagram

Closes #14485

- Use a Mermaid diagram instead of an image (see #25883)
- Update terms used in the diagram
- Ensure that the name of the Teleport cluster is consistent between the
  diagram and the body text

* Docs: Apply Styling to Graph (#26154)

* apply styling to graph

* remove unused image

---------

Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants